-
-
Notifications
You must be signed in to change notification settings - Fork 479
Auto-update aws-lc to v1.61.4 #8272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the aws-lc
package to version v1.61.4
. The change itself is correct, adding the new version and its corresponding hash while maintaining the descending order of versions. I have one suggestion regarding the long-term maintainability of this package file.
add_urls("https://github.com/aws/aws-lc/archive/refs/tags/$(version).tar.gz", | ||
"https://github.com/aws/aws-lc.git") | ||
|
||
add_versions("v1.61.4", "443b62dbb51bb4ce1ce16150fa555da4182e3ba4c928f57f74eb07097138893c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the new version is correct, the list of versions in this file is growing quite long. To improve long-term maintainability, I suggest establishing a policy to prune older, unsupported versions. For example, you could keep only the 10 most recent versions and remove the oldest one whenever a new version is added. This would likely require an update to the autoupdate.lua
script to automate the cleanup.
New version of aws-lc detected (package version: v1.53.0, last github version: v1.61.4)