-
-
Notifications
You must be signed in to change notification settings - Fork 447
libhat: new package #7253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libhat: new package #7253
Conversation
packages/l/libhat/xmake.lua
Outdated
]]) | ||
local opt = {} | ||
if package:config("module") and package:has_tool("cxx", "cl") then | ||
opt.cxflags = {"/EHsc", "/experimental:module"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/experimental:module
is deprecated and will likely be removed in a future VS version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/experimental:module
is deprecated and will likely be removed in a future VS version
Yet it lacks of info how to guard it properly, since it is not removed yet. https://learn.microsoft.com/en-us/cpp/build/reference/experimental-module?view=msvc-170&viewFallbackFrom=msvc-170.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see in the libhat source, it's not using msvc's dead experimental modules, just the standard ones, so that doesn't matter in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well some users might still have outdated MSVC, so they would stick with /MD runtime, /EHsc and /experimental:module at this case anyway? Yet I decided to remove this as it has not been released tag and is sort of nightly feature.
#10 (comment)