Skip to content

libhat: new package #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 2, 2025
Merged

libhat: new package #7253

merged 13 commits into from
Jun 2, 2025

Conversation

SMlc666
Copy link
Contributor

@SMlc666 SMlc666 commented May 31, 2025

#10 (comment)

libhat
A modern, high-performance library for C++20 designed around game hacking

@luadebug luadebug changed the title add: libhat libhat: new package May 31, 2025
@luadebug luadebug requested a review from waruqi June 1, 2025 14:55
]])
local opt = {}
if package:config("module") and package:has_tool("cxx", "cl") then
opt.cxflags = {"/EHsc", "/experimental:module"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/experimental:module is deprecated and will likely be removed in a future VS version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/experimental:module is deprecated and will likely be removed in a future VS version

Yet it lacks of info how to guard it properly, since it is not removed yet. https://learn.microsoft.com/en-us/cpp/build/reference/experimental-module?view=msvc-170&viewFallbackFrom=msvc-170.

Copy link
Contributor

@qudix qudix Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see in the libhat source, it's not using msvc's dead experimental modules, just the standard ones, so that doesn't matter in this case.

Copy link
Contributor

@luadebug luadebug Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well some users might still have outdated MSVC, so they would stick with /MD runtime, /EHsc and /experimental:module at this case anyway? Yet I decided to remove this as it has not been released tag and is sort of nightly feature.

@waruqi waruqi merged commit b482168 into xmake-io:dev Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants