Skip to content

Conversation

gululudu
Copy link
Contributor

The wdk.sign.digest_algorithm field was previously undocumented. This commit adds its description to clarify its role in specifying the hash algorithm used during driver signing.

Copy link

vercel bot commented Oct 17, 2025

@gululudu is attempting to deploy a commit to the waruqi's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for mellow-creponne-9cce3d ready!

Name Link
🔨 Latest commit 08ab85d
🔍 Latest deploy log https://app.netlify.com/projects/mellow-creponne-9cce3d/deploys/68f24ad0db11e100073d18a0
😎 Deploy Preview https://deploy-preview-245--mellow-creponne-9cce3d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Summary of Changes

Hello @gululudu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity and completeness of the documentation by adding a description for the wdk.sign.digest_algorithm field. This field is crucial for specifying the hash algorithm used during driver signing. Alongside the API description update, practical code examples have been enhanced to guide users on how to properly configure this setting, ensuring better understanding and correct implementation of WDK driver signing processes.

Highlights

  • Documentation Update: The previously undocumented wdk.sign.digest_algorithm field has been added to the API description, clarifying its role in specifying the hash algorithm for driver signing in both English and Chinese documentation.
  • Example Code Enhancement: All relevant WDK driver signing examples in the documentation have been updated to include the wdk.sign.digest_algorithm field, demonstrating its usage with sha256.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the wdk.sign.digest_algorithm configuration option, which was previously missing. The changes are well-contained and update the API reference, examples, and a blog post in both English and Chinese.

I've suggested a couple of minor formatting improvements to the markdown tables to improve readability and consistency. Overall, this is a good and necessary documentation update.

| wdk.sign.store | Set wdk code signing store |
| wdk.sign.certfile | Set wdk code signing certificate file |
| wdk.sign.thumbprint | Set wdk code signing fingerprint |
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The alignment of this new table row is inconsistent with the rows above it. For better readability and maintainability, please adjust the spacing to align the columns.

Suggested change
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm |
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm |

Comment on lines +2603 to +2620
| 扩展配置名 | 配置描述 |
| --- | --- |
| fortran.moduledir | 设置 fortran 模块的输出目录 |
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) |
| objc.build.arc | 设置启用或禁用 objc 的 arc |
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc |
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier |
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 |
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 |
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) |
| wdk.env.winver | 设置 wdk 的 win 支持版本 |
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 |
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 |
| wdk.sign.mode | 设置 wdk 的代码签名模式 |
| wdk.sign.store | 设置 wdk 的代码签名 store |
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 |
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 |
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The alignment of this table is inconsistent, making it difficult to read. Please reformat the table to properly align the columns. Consistent formatting improves readability and maintainability of the documentation.

Suggested change
| 扩展配置名 | 配置描述 |
| --- | --- |
| fortran.moduledir | 设置 fortran 模块的输出目录 |
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) |
| objc.build.arc | 设置启用或禁用 objc 的 arc |
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc |
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier |
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 |
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 |
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) |
| wdk.env.winver | 设置 wdk 的 win 支持版本 |
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 |
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 |
| wdk.sign.mode | 设置 wdk 的代码签名模式 |
| wdk.sign.store | 设置 wdk 的代码签名 store |
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 |
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 |
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 |
| 扩展配置名 | 配置描述 |
| ------------------------- | ---------------------------------------- |
| fortran.moduledir | 设置 fortran 模块的输出目录 |
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) |
| objc.build.arc | 设置启用或禁用 objc 的 arc |
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc |
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier |
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 |
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 |
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) |
| wdk.env.winver | 设置 wdk 的 win 支持版本 |
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 |
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 |
| wdk.sign.mode | 设置 wdk 的代码签名模式 |
| wdk.sign.store | 设置 wdk 的代码签名 store |
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 |
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 |
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 |

@waruqi waruqi merged commit 574f9cb into xmake-io:master Oct 17, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants