-
-
Notifications
You must be signed in to change notification settings - Fork 131
docs: add missing wdk.sign.digest_algorithm description #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gululudu is attempting to deploy a commit to the waruqi's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for mellow-creponne-9cce3d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @gululudu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity and completeness of the documentation by adding a description for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the wdk.sign.digest_algorithm
configuration option, which was previously missing. The changes are well-contained and update the API reference, examples, and a blog post in both English and Chinese.
I've suggested a couple of minor formatting improvements to the markdown tables to improve readability and consistency. Overall, this is a good and necessary documentation update.
| wdk.sign.store | Set wdk code signing store | | ||
| wdk.sign.certfile | Set wdk code signing certificate file | | ||
| wdk.sign.thumbprint | Set wdk code signing fingerprint | | ||
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of this new table row is inconsistent with the rows above it. For better readability and maintainability, please adjust the spacing to align the columns.
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm | | |
| wdk.sign.digest_algorithm | Set wdk code signing digest algorithm | |
| 扩展配置名 | 配置描述 | | ||
| --- | --- | | ||
| fortran.moduledir | 设置 fortran 模块的输出目录 | | ||
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) | | ||
| objc.build.arc | 设置启用或禁用 objc 的 arc | | ||
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc | | ||
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier | | ||
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 | | ||
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 | | ||
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) | | ||
| wdk.env.winver | 设置 wdk 的 win 支持版本 | | ||
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 | | ||
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 | | ||
| wdk.sign.mode | 设置 wdk 的代码签名模式 | | ||
| wdk.sign.store | 设置 wdk 的代码签名 store | | ||
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 | | ||
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 | | ||
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of this table is inconsistent, making it difficult to read. Please reformat the table to properly align the columns. Consistent formatting improves readability and maintainability of the documentation.
| 扩展配置名 | 配置描述 | | |
| --- | --- | | |
| fortran.moduledir | 设置 fortran 模块的输出目录 | | |
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) | | |
| objc.build.arc | 设置启用或禁用 objc 的 arc | | |
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc | | |
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier | | |
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 | | |
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 | | |
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) | | |
| wdk.env.winver | 设置 wdk 的 win 支持版本 | | |
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 | | |
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 | | |
| wdk.sign.mode | 设置 wdk 的代码签名模式 | | |
| wdk.sign.store | 设置 wdk 的代码签名 store | | |
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 | | |
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 | | |
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 | | |
| 扩展配置名 | 配置描述 | | |
| ------------------------- | ---------------------------------------- | | |
| fortran.moduledir | 设置 fortran 模块的输出目录 | | |
| ndk.arm_mode | 设置 ndk 的 arm 编译模式 (arm/thumb) | | |
| objc.build.arc | 设置启用或禁用 objc 的 arc | | |
| objc++.build.arc | 设置启用或禁用 objc++ 的 arc | | |
| xcode.bundle_identifier | 设置 xcode 工具链的 Bundle Identifier | | |
| xcode.mobile_provision | 设置 xcode 工具链的证书信息 | | |
| xcode.codesign_identity | 设置 xcode 工具链的代码签名标识 | | |
| wasm.preloadfiles | 设置 wasm 打包的预加载文件 (preload file) | | |
| wdk.env.winver | 设置 wdk 的 win 支持版本 | | |
| wdk.umdf.sdkver | 设置 wdk 的 umdf sdk 版本 | | |
| wdk.kmdf.sdkver | 设置 wdk 的 kmdf sdk 版本 | | |
| wdk.sign.mode | 设置 wdk 的代码签名模式 | | |
| wdk.sign.store | 设置 wdk 的代码签名 store | | |
| wdk.sign.certfile | 设置 wdk 的代码签名证书文件 | | |
| wdk.sign.thumbprint | 设置 wdk 的代码签名指纹 | | |
| wdk.sign.digest_algorithm | 设置 wdk 的代码签名摘要算法 | |
The wdk.sign.digest_algorithm field was previously undocumented. This commit adds its description to clarify its role in specifying the hash algorithm used during driver signing.