Safety critical bounds checking is off-by-one in sgrproj_box_ab_internal #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
+ Coverage 86.78% 86.80% +0.01%
==========================================
Files 84 84
Lines 33308 33308
==========================================
+ Hits 28908 28913 +5
+ Misses 4400 4395 -5
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
CodesInChaos
force-pushed
the
bounds-off-by-one
branch
from
de81c12
to
c95cd61
Compare
shssoichiro
reviewed
Apr 2, 2023
shssoichiro
approved these changes
Apr 2, 2023
|
Re. integer overflows do you mean if the strides overflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the main part of #3161
I believe the potential for integer overflows still makes it unsound though.