Clippy

xiph · Oct 3, 2023 · 3aecd94 · 3aecd94
1 parent da45520
commit 3aecd94
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/api/test.rs b/src/api/test.rs
@@ -278,7 +278,7 @@ fn send_test_frame<T: Pixel>(ctx: &mut Context<T>, content_value: T) {
 fn get_frame_invariants<T: Pixel>(
   ctx: Context<T>,
 ) -> impl Iterator<Item = Option<FrameInvariants<T>>> {
-  ctx.inner.frame_data.into_iter().map(|(_, v)| v.map(|v| v.fi))
+  ctx.inner.frame_data.into_values().map(|v| v.map(|v| v.fi))
 }
 
 #[interpolate_test(0, 0)]

diff --git a/src/bin/common.rs b/src/bin/common.rs
@@ -365,7 +365,7 @@ fn build_speed_long_help() -> Option<&'static str> {
     )
   });
 
-  Some(&help)
+  Some(help)
 }
 
 #[cfg(not(feature = "serialize"))]

diff --git a/src/encoder.rs b/src/encoder.rs
@@ -1354,8 +1354,8 @@ fn write_key_frame_obus<T: Pixel>(
 }
 
 /// Write into `dst` the difference between the blocks at `src1` and `src2`
-fn diff<'a, T: Pixel>(
-  dst: &'a mut [MaybeUninit<i16>], src1: &PlaneRegion<'_, T>,
+fn diff<T: Pixel>(
+  dst: &mut [MaybeUninit<i16>], src1: &PlaneRegion<'_, T>,
   src2: &PlaneRegion<'_, T>,
 ) {
   debug_assert!(dst.len() % src1.rect().width == 0);

diff --git a/tests/binary.rs b/tests/binary.rs
@@ -9,7 +9,7 @@ mod binary {
   use std::path::{Path, PathBuf};
 
   fn get_y4m_input() -> Vec<u8> {
-    let mut input = File::open(&format!(
+    let mut input = File::open(format!(
       "{}/tests/small_input.y4m",
       env!("CARGO_MANIFEST_DIR")
     ))
@@ -45,7 +45,7 @@ mod binary {
 
   fn get_common_cmd(outfile: &Path) -> Command {
     let mut cmd = get_rav1e_command();
-    cmd.args(&["--bitrate", "1000"]).arg("-o").arg(outfile).arg("-y");
+    cmd.args(["--bitrate", "1000"]).arg("-o").arg(outfile).arg("-y");
     cmd
   }
 
@@ -54,7 +54,7 @@ mod binary {
     let outfile = get_tempfile_path("ivf");
 
     get_rav1e_command()
-      .args(&["--quantizer", "100"])
+      .args(["--quantizer", "100"])
       .arg("-o")
       .arg(&outfile)
       .arg("-")
@@ -101,7 +101,7 @@ mod binary {
     let passfile = get_tempfile_path("pass");
 
     get_common_cmd(&outfile)
-      .args(&["--reservoir-frame-delay", "14"])
+      .args(["--reservoir-frame-delay", "14"])
       .arg("--first-pass")
       .arg(&passfile)
       .arg("-")
@@ -110,7 +110,7 @@ mod binary {
       .success();
 
     get_common_cmd(&outfile)
-      .args(&["--reservoir-frame-delay", "14"])
+      .args(["--reservoir-frame-delay", "14"])
       .arg("--second-pass")
       .arg(&passfile)
       .arg("-")
-Original file line number
+Diff line change
@@ Expand Up / @@ -365,7 +365,7 @@ fn build_speed_long_help() -> Option<&'static str> { @@
         )
       });
-      Some(&help)
+      Some(help)
     }
     #[cfg(not(feature = "serialize"))]
@@ Expand Down @@