Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OGG-FLAC support #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add OGG-FLAC support #19

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2020

As I stated in #18, I had a work-in-progress fork that adds OGG-FLAC support to this library. I believe it is now ready to be pulled and integrated into the main project.

I've tested building and running this code on a simple instance that passes an OGG-FLAC stream to this version of libshout, and streams seem to work well.

Caveats:

  • a new m4 file must be added under the m4 folder - it can be found here as flac.m4, but I couldn't include it in this PR, since the m4 folder is itself a submodule (presumably to the original Gitlab repo)
  • there are problems with timeouts when streaming long segments of silence, like with at least one another codec as pointed out by @rillian here, and codec_flac here doesn't do manual page flushes. I'm not sure if it might be worth pointing out somewhere
  • In private test use, I've heard reports of some media players (such as VLC) having issues due to discontinuities over timestamps after song changes (the timestamps get reset to zero on song change, which causes VLC to spam "timestamp conversion failed"), but it's not been tested if this also happens on other OGG streams and could equally well be the fault of the program that actually feeds the stream to libshout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant