#12 better AMD #13
Open
#12 better AMD #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also https://github.com/umdjs/umd |
|
kusmierz: Would you mind trying this again, starting from a clean copy of index.js and only making the changes you meant to make. As it stands, this pull request is composed of 4 commits - one in which formatting was incorrectly changed and 3 in which you attempted to revert the unwanted changes manually. This makes for a messy history. The other option would be to squash the 4 commits into one. |
kusmierz
force-pushed
the
12-better-amd
branch
from
c5bd995
to
67d904f
Compare
|
@kurtmilam done, sorry for a problem and thanks for the squash option, haven't knew about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Sorry for formatting issues, in fact I modified just top and the very bottom of the script.