Release 3356 | Raise error when error 413 is likely to happen #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 21, 2024 17:48
huNt-FMJ
reviewed
May 27, 2024
huNt-FMJ
reviewed
May 27, 2024
huNt-FMJ
reviewed
May 27, 2024
| end | ||
| end | ||
|
|
||
| MSTEAMS_MESSAGE_SIZE_LIMIT = 21_000 |
There was a problem hiding this comment.
Do you have a reference for that limit? It would be great to add that reference.
There was a problem hiding this comment.
There is a limit stated here: https://learn.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/add-incoming-webhook
But it did not seemed to match the actual results of running (I tried multiple times)
huNt-FMJ
reviewed
May 27, 2024
huNt-FMJ
reviewed
May 27, 2024
huNt-FMJ
reviewed
May 27, 2024
huNt-FMJ
approved these changes
May 27, 2024
Co-authored-by: Nej <[email protected]>
…ile/msteams_hermes into release-3356/handle-413-response
huNt-FMJ
reviewed
May 28, 2024
huNt-FMJ
reviewed
May 28, 2024
Co-authored-by: Nej <[email protected]>
Co-authored-by: Nej <[email protected]>
msd117c
approved these changes
Jun 5, 2024
jamuc
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR outcome
It raise an error when the currently known (it does not really peek/parse the response body to decide if an error happened) limit of the messages is reached
Side refactorings
gemspec/Gemfilefile3.1+webmockgem and add tests for the.delivermethod