Skip to content

fix: remove unused isValidFootnoteId helper#989

Open
xiaolai wants to merge 1 commit into
mainfrom
fix/audit-987
Open

fix: remove unused isValidFootnoteId helper#989
xiaolai wants to merge 1 commit into
mainfrom
fix/audit-987

Conversation

@xiaolai
Copy link
Copy Markdown
Owner

@xiaolai xiaolai commented Jun 2, 2026

Closes #987

The helper was exported but never consumed in production code — only by
its own tests. Removing it (and its describe block) eliminates dead code.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@xiaolai xiaolai added the audit Codebase audit finding label Jun 2, 2026
@xiaolai
Copy link
Copy Markdown
Owner Author

xiaolai commented Jun 2, 2026

VERIFIED — The audit finding is resolved. The diff deletes isValidFootnoteId (and its JSDoc) from operations.ts, removes it from the test file's import, and deletes the corresponding describe block — exactly matching the issue's suggested fix with no scope creep and no changes to extractFootnoteIds or findFootnoteDefinition.

@xiaolai xiaolai enabled auto-merge (squash) June 2, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit Codebase audit finding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[audit] dead-code: isValidFootnoteId in footnotePopup/operations.ts is exported but only used by its own tests

1 participant