Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow empty attachments #98

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

meain
Copy link
Contributor

@meain meain commented Dec 19, 2023

Closes #96

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e85597e) 52.63% compared to head (6628ef0) 52.51%.
Report is 1 commits behind head on master.

Files Patch % Lines
attach.go 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   52.63%   52.51%   -0.13%     
==========================================
  Files           7        7              
  Lines        1290     1293       +3     
==========================================
  Hits          679      679              
- Misses        542      545       +3     
  Partials       69       69              
Flag Coverage Δ
unittests 52.51% <40.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xhit xhit merged commit 3a06b6e into xhit:master Dec 19, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support attachments with empty data
3 participants