Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ContentID if provided to lookup attachments #103

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

meain
Copy link
Contributor

@meain meain commented Mar 8, 2024

File struct now has an optional ContentID field which if provided is used to look up inline attachments in the body instead of Name.

Closes #101

File struct now has an optional ContentID field which if provided is
used to look up inline attachments in the body instead of Name.
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 52.49%. Comparing base (e26e0d1) to head (8e60fa9).

Files Patch % Lines
message.go 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   52.65%   52.49%   -0.17%     
==========================================
  Files           7        7              
  Lines        1297     1301       +4     
==========================================
  Hits          683      683              
- Misses        545      549       +4     
  Partials       69       69              
Flag Coverage Δ
unittests 52.49% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xhit xhit merged commit 500bfa5 into xhit:master Mar 11, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifying inline attachments with CID instead of name
3 participants