Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TreeMap cross-platform #3866

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

TomTirapani
Copy link
Member

See issue: #3818
See Toolbox PR: xh/toolbox#747

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler
Copy link
Member

Is this completely driven by mask and errorMessage?

@lbwexler
Copy link
Member

Tom and I discussed this -- Tom is going to take another pass and see if he can make mask and errorMessage cross-platform -- this would be more of a breaking change, but could give us much more bang for the buck, and would make a cross-platform version of this (and maybe other components) trivial.

@lbwexler lbwexler marked this pull request as draft December 20, 2024 15:36
+ Make `Mask` cross-platform
+ Make `LoadingIndicator` cross-platform
@TomTirapani
Copy link
Member Author

Updated this and the toolbox PR to make ErrorMessage and Mask cross-platform, and therefore not require two implementations of TreeMap / SplitMap.

Also made LoadingIndicator cross-platform as it was low-hanging fruit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants