Update for Webpack 5 #2903
Merged
Update for Webpack 5 #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
+ Previous dual files accommodated older versions of hoist-dev-utils - this HR version will require HDU v6+
# Conflicts: # CHANGELOG.md # package.json # yarn.lock
# Conflicts: # yarn.lock
# Conflicts: # CHANGELOG.md # yarn.lock
# Conflicts: # CHANGELOG.md
|
@amcclain As discussed yesterday, I've updated this PR to be compatible with both Webpack 4 & Webpack 5 versions of hoist-dev-utils. We should be able to move ahead with this PR prior independently of apps upgrading their hoist-dev-utils. |
+ Don't update hoist-dev-utils version spec'd by hoist-react yet - we can do that as soon as we merge and start to use dev-utils. + Add changelog entry noting that this version will be compatible with the upcoming HDU v6.
ghsolomon
pushed a commit
that referenced
this pull request
May 18, 2022
+ Includes new `index-manifest.html` file required for compatibility with upcoming hoist-dev-utils v6 release. + Imports dependency package versions in a way that works with both current webpack 4 and upcoming webpack 5 build tooling. Co-authored-by: Anselm McClain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: xh/hoist-dev-utils#39
See: xh/toolbox#562
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.