Skip to content

Commit

Permalink
#29 - Fixed chunk collection so that similarly named apps within a pr…
Browse files Browse the repository at this point in the history
…oject do not load each other's app chunk.
  • Loading branch information
cnrudd committed Feb 5, 2024
1 parent e7a7685 commit 01746b7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## v8.0-SNAPSHOT

### 🐞 Bug Fixes

* Fixed chunk collection so that similarly named apps within a project do not load each other's app chunk.

## v7.0.0 - 2023-07-19

* Updated `@xh/eslint-config` to v6.0, for use with Typescript v5.1+ and Hoist React v59+.
Expand Down
2 changes: 1 addition & 1 deletion configureWebpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ async function configureWebpack(env) {
template: path.resolve(hoistPath, `static/index-manifest.html`),
filename: `${jsAppName}/index.html`,
// Only include chunks that contain the js app name
chunks: chunkNames.filter(it => it.includes(jsAppName)),
chunks: chunkNames.filter(it => it.startsWith(jsAppName) || it.includes('~' + jsAppName)),
// No need to minify the HTML itself
minify: false,
// Flag read within template file to include apple icon.
Expand Down

0 comments on commit 01746b7

Please sign in to comment.