-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic download / delete chapters #337
Open
merlinmarijn
wants to merge
11
commits into
xgi:master
Choose a base branch
from
merlinmarijn:Auto-download-and-delete
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merlinmarijn
commented
Feb 5, 2024
•
edited
Loading
edited
- Added auto download on startup
- Added auto download on loading series detail page
- Added auto download when loading new chapter
- Added value to determine how many unread chapters should be downloaded
- Added auto delete read chapters on startup
- Added auto delete read chapters on loading series detail page
- Added a regex to check if the series is a site or filesystem (can be used for other things)
- Added auto download on startup - Added auto download on loading series detail page - Added auto download when loading new chapter - Added value to determine how many unread chapters should be downloaded - Added auto delete read chapters on startup - Added auto delete read chapters on loading series detail page - Added a regex to check if url is valid to check if series is a site or filesystem (can be used for other things)
merlinmarijn
changed the title
Added functionalities
Added automatic download / delete chapters
Feb 7, 2024
Instead of doing each action after each other and reassigning the new data to itself, just chained the actions together on the initial assignment
- Added a variable to showing the download notification, so when you're reading manga and going to the next chapter it doesnt everytime show the notification. The notification variable is set to true so no other code needs to ask if it wants to show the notification and keeps working like it used to
- Fixed intense lag when downloading (AFAIK) - Fixed it downloading any chapter even if there we're multiple language's, now downloads only from the language you have selected in settings. - Fixed downloading local files
- Fixed variable given to the function to download since i added language filtering to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.