Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating dft and replacing it with fft #161

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Conversation

roxyboy
Copy link
Member

@roxyboy roxyboy commented Jul 2, 2021

A PR to initiate a deprecation cycle for xrft.dft and to replace it with xrft.fft. As the tests all pass using dft, none of the previous behaviors should break with only the warning messages changing.

@roxyboy
Copy link
Member Author

roxyboy commented Jul 2, 2021

@santisoler @lanougue Do you have any input on this? Follow our discussion in #154, I tried unifying xrft to fft.

Copy link
Contributor

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙌🏼

@roxyboy
Copy link
Member Author

roxyboy commented Jul 16, 2021

@rabernat This deprecation cycle of removing dft and unifying the default function to fft will result in quite a drastic change down the line but would you agree with this? It seems that having two functions (fft and dft) is confusing to users.

@roxyboy roxyboy merged commit a57a87c into xgcm:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants