Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDAPI-552 update swagger spec to be oa2 compliant #222

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RVanhuysseXenit
Copy link
Contributor

This has already been done twice without being committed to the main repository. We should make this a permanent change

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-552

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • [N/A] Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

WimCrols
WimCrols previously approved these changes Jul 10, 2024
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to give feedback. If this runs in the appropriate tools, then it is good.

CHANGELOG.md Outdated Show resolved Hide resolved
WimCrols
WimCrols previously approved these changes Jul 10, 2024
todorinskiz
todorinskiz previously approved these changes Jul 17, 2024

tasks.register("buildWebsiteScript", Exec) {
setGroup "documentation"
commandLine 'chmod', '+x', './build-website.sh'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can commit +x with Git, no need to execute it every time

put from: file("${layout.buildDirectory.get()}/website-alfred-api_${today}.tar.gz"), into: "${remoteHomeDir}/docs.xenit.eu/"
execute "mv ${remoteHomeDir}/docs.xenit.eu/alfred-api ${remoteHomeDir}/docs.xenit.eu/alfred-api_${today}_back"
execute "mkdir -p ${remoteHomeDir}/docs.xenit.eu/back/"
execute "tar vxzf ${remoteHomeDir}/docs.xenit.eu/website-alfred-api_${today}.tar.gz -C ${remoteHomeDir}/docs.xenit.eu/back/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order might be a bit confusing, would be best to first complete the backup, then deploy the new docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants