Remove unnecessary volume mount from local build command in README.md…

…; move `cross` config in Cargo.toml
xenago · Jun 1, 2024 · c189951 · c189951
1 parent 5213573
commit c189951
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -48,3 +48,7 @@ assets = [
 ]
 post_install_script = "debian/postinst"
 post_uninstall_script = "debian/postrm"
+
+# Required by `cross` tool for glibc 2.17 CentOS-compatible cross-compilation
+[workspace.metadata.cross.target.aarch64-unknown-linux-gnu]
+image = "ghcr.io/cross-rs/aarch64-unknown-linux-gnu:main-centos"
diff --git a/README.md b/README.md
@@ -361,9 +361,9 @@ I generally find it easiest to run `build.sh` inside a temporary container:
 
 3. Run the build script inside a temporary container, setting `LIBNSS_SHIM_VERSION` and the cloned repo path as desired:
 
-       sudo docker run -e "LIBNSS_SHIM_VERSION=0.0.0" -v /path/to/cloned/libnss_shim:/libnss_shim -v /var/run/docker.sock:/var/run/docker.sock --rm -it quay.io/pypa/manylinux2014_x86_64:latest bash /libnss_shim/build.sh
+       sudo docker run -e "LIBNSS_SHIM_VERSION=0.0.0" -v /path/to/cloned/libnss_shim:/libnss_shim --rm -it quay.io/pypa/manylinux2014_x86_64:latest bash /libnss_shim/build.sh
 
-   Note that this requires 
+   Note: [the `manylinux2014` container](https://github.com/pypa/manylinux) is available for various architectures.
 
 4. The build script will output packages in the following subdirectories of the cloned repo: