use color output by default #329
Conversation
| addopts = -ra --maxfail=1 | ||
| addopts = -ra --maxfail=1 --color=yes |
There was a problem hiding this comment.
What's the rationale? It's rather customary to only use color when output is a tty (the default --color=auto)
Also, the commit name does not say which tool is impacted
There was a problem hiding this comment.
The goal is to have some color in Jenkins' logs, without needing to modify all the pipelines.
Is there a reason we might not want some color?
There was a problem hiding this comment.
The reason for auto as a default IIRC is so the output gets full-text and stays greppable etc. While it is likely not very important in this case, hardcoding an option in the repo just for the sake of Jenkins is not ideal in general, it would seem more adequate to have Jenkins set it using PYTEST_ADDOPTS envvar instead.
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/color-output-default-krty
branch
from
b3fe742 to
fa869a5
Compare
No description provided.