tests/storage/linstor: Add test for forgetting and introducing Linstor SR #279
+73
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushikeshjadhav
force-pushed
the
feat-storage-linstor-611
branch
from
221d797 to
988e81e
Compare
rushikeshjadhav
force-pushed
the
feat-storage-linstor-611
branch
from
988e81e to
3c19d5a
Compare
rushikeshjadhav
force-pushed
the
feat-storage-linstor-611
branch
2 times, most recently
from
7e8b277 to
75e8a4e
Compare
|
I had a look, nothing I'd need to comment on I think, so I leave it to the other reviewers. |
Wescoeur
requested changes
May 7, 2025
lib/host.py
Outdated
Comment on lines
136
to
139
| if isinstance(args, dict): | ||
| command += [stringify(key, value) for key, value in args.items()] | ||
| elif isinstance(args, list): | ||
| command += [stringify(key, value) for key, value in args] |
There was a problem hiding this comment.
Suggested change
| if isinstance(args, dict): | |
| command += [stringify(key, value) for key, value in args.items()] | |
| elif isinstance(args, list): | |
| command += [stringify(key, value) for key, value in args] | |
| resolved_args = None | |
| if isinstance(args, list): | |
| resolved_args = args | |
| else: | |
| resolved_args = args.items() | |
| command += [stringify(key, value) for key, value in resolved_args] |
lib/sr.py
Outdated
| return self.pool.master.xe('sr-param-get', {'uuid': self.uuid, 'param-name': param}) | ||
|
|
||
| def type(self): | ||
| return self.pool.master.xe('sr-param-get', {'uuid': self.uuid, 'param-name': 'type'}) |
There was a problem hiding this comment.
Suggested change
| return self.pool.master.xe('sr-param-get', {'uuid': self.uuid, 'param-name': 'type'}) | |
| return self.param_get('type') |
lib/sr.py
Outdated
| @@ -147,6 +148,17 @@ def main_host(self): | |||
| def content_type(self): | |||
| return self.pool.master.xe('sr-param-get', {'uuid': self.uuid, 'param-name': 'content-type'}) | |||
There was a problem hiding this comment.
Suggested change
| return self.pool.master.xe('sr-param-get', {'uuid': self.uuid, 'param-name': 'content-type'}) | |
| return self.param_get('content-type') |
- Added support for handling both dictionary and list-based arguments. - Fixed command formatting for `config:key=value` scenarios. Signed-off-by: Rushikesh Jadhav <[email protected]>
- `param_get()`: Fetch a specific SR parameter. - `type()`: Retrieve SR type. - `introduce()`: Introduce SR. Signed-off-by: Rushikesh Jadhav <[email protected]>
…_introduce_sr` - Validates the ability to forget an SR and properly reintroduce it. - Ensures all PBD configurations are stored and restored correctly. - Checks that exceptions are raised when querying a forgotten SR. - Restores the SR and verifies successful reattachment of PBDs. Signed-off-by: Rushikesh Jadhav <[email protected]>
rushikeshjadhav
force-pushed
the
feat-storage-linstor-611
branch
from
75e8a4e to
1b97717
Compare
Millefeuille42
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
test_forget_and_introduce_srintest_linstor_sr.pyto validate forgetting and reintroducing an SR, ensuring correct PBD restoration and proper exception handling.Updated SR class in
sr.pywith methods for retrieving parameters, getting type, forgetting, and introducing SR.