-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated RPU test #253
Draft
ydirson
wants to merge
70
commits into
master
Choose a base branch
from
install-rpu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Automated RPU test #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
requested review from
gthvn1,
stormi,
tescande,
benjamreis and
gduperrey
September 5, 2024 16:41
ydirson
force-pushed
the
install-rpu
branch
15 times, most recently
from
September 11, 2024 14:31
5b07d3c
to
eabb732
Compare
ydirson
force-pushed
the
install-rpu
branch
9 times, most recently
from
September 16, 2024 08:51
21ebbc0
to
1ab2c52
Compare
…store Signed-off-by: Yann Dirson <[email protected]>
This gets back to DHCP, as static IPs are not needed for this part of the job.
FIXME: config.py seems a bad idea after all FIXME: duplicated logic should be factored out
FIXME: should be in job instead
When using --hosts=cache://... it is much too early for such a check, so we have to give the info manually, and the script would not allow this. And honor it not just for "collect".
Can only succeed with a certificate refresh in between
FIXME: switching to static IPs should be only when really needed
FIXME: dependency on tests from another module don't seem to get properly located by pytest-dependency (--ignore-unknown-dependency required)
FIXME: how useful?
FIXME: had to keep a copy of perform_upgrade() after its functionality was moved to vm_booted_with_installer fixture, must find a proper solution for that
Useful to get the debug output from commands.ssh() Signed-off-by: Yann Dirson <[email protected]>
Error code would be concatenated with command output without even a space. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out and based on #226