Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install-driven enhancements #242

Merged
merged 24 commits into from
Aug 30, 2024
Merged

Install-driven enhancements #242

merged 24 commits into from
Aug 30, 2024

Commits on Aug 28, 2024

  1. host.main_sr: don't return "<not in database>" as UUID on missing def… 

    …ault-SR

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4d29d7d View commit details
    Browse the repository at this point in the history

  2. Host: rename main_sr to main_sr_uuid 

    Other methods to get SRs return `SR` objects, this was inconsistent.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1450f8c View commit details
    Browse the repository at this point in the history

  3. local_cmd: log command to be run, like ssh does 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7a987e4 View commit details
    Browse the repository at this point in the history

  4. VM: fix name of method dealing with CD insertion, provide a generic API 

    "vm-cd-insert" does not mount anything, as the need for a subsequent
"mount" in the only test using it shows.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    84af37b View commit details
    Browse the repository at this point in the history

  5. VM: add logging for CD insert/eject 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    15ce1bd View commit details
    Browse the repository at this point in the history

  6. _ssh: remove duplicate default values 

    The entrypoint is ssh(), and the default values are already there.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0d985f3 View commit details
    Browse the repository at this point in the history

  7. Remove redundant logs on VM creation 

    Since f9b5365 the VM ctor takes care of
reporting this info.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e3dacc0 View commit details
    Browse the repository at this point in the history

  8. host.import_vm: report when VM not found in cache 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7f963e1 View commit details
    Browse the repository at this point in the history

  9. host: split cached_vm identification from import_vm 

    This will be useful to the plugin that allows not rerunning a cached
dependency: it needs to probe the cache.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    820b38d View commit details
    Browse the repository at this point in the history

  10. requirements: cleanup cruft, avoid duplication in README 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    16e44d4 View commit details
    Browse the repository at this point in the history

  11. try_get_and_store_ip: raise boot timeout for nested tests 

    When testing in a nested setup, 2 min is not enough to boot a Debian 12
to the point the XS agent has published to xenstore.

5 min should be enough for everyone.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7282e94 View commit details
    Browse the repository at this point in the history

  12. test_guest_tools_unix: make requirements more explicit 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    95f7c1b View commit details
    Browse the repository at this point in the history

  13. test_basic_without_ssh: split start/stop test from those needing a ru… 

    …nning VM.

There is no other inter-test dependency in this file, this allows to stop
using @pytest.mark.incremental here.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6d4a5b1 View commit details
    Browse the repository at this point in the history

  14. test_basic_without_ssh: clarify requirements a bit (fixes #244) 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4f79b05 View commit details
    Browse the repository at this point in the history

  15. test_guest_tools_unix: use a fixture instead of expecting test_install 

    Same as for test_basic_without_ssh, and this allows to stop using
@pytest.mark.incremental here too.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e445e03 View commit details
    Browse the repository at this point in the history

  16. Drop "incremental" marker. 

    Previous commits removed its two only uses, replaced by an autouse fixture.
Other possible uses would be covered (with a more fine-grained approach)
by pytest-dependency.

This frees the global pytest_runtest_makereport hook for potential reuse.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    14eeee6 View commit details
    Browse the repository at this point in the history

  17. conftest: regroup all pytest hooks together, separated from fixtures 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    980080c View commit details
    Browse the repository at this point in the history

  18. CACHE_IMPORTED_VM: parse only once 

    We will need this value in other places.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c66ddcf View commit details
    Browse the repository at this point in the history

  19. BaseVM: add missing param_* methods 

    And make the whole easier to copypaste.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a41cdbd View commit details
    Browse the repository at this point in the history

  20. vm: remove duplicate file_exists() 

    Reported by mypy.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    04008cd View commit details
    Browse the repository at this point in the history

  21. Host.join_pool(): update the host's pool after new pool is joined 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2fe3e54 View commit details
    Browse the repository at this point in the history

  22. pytest: do not restrict timestamping to CLI 

    We want to have it in log-file.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b700f55 View commit details
    Browse the repository at this point in the history

  23. pytest: add milliseconds to log timestamp 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4de1e3d View commit details
    Browse the repository at this point in the history

  24. LocalCommandFailed: fix ctor upcall 

    Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    462ff23 View commit details
    Browse the repository at this point in the history