Wait for 10 minutes before the 5th sr-destroy attempt #172
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have code which retries a failed sr-destroy, when the cause is remaining hidden VDIs which haven't been garbage-collected yet, and it's enough in most cases, but not always. Sometimes, the force-gc that is triggered by SM before the delete operation is not enough. VDIs that look like they should be removed remain, and are removed only a bit later, when the normal garbage collector runs. This may be related to the fact that the forced GC operation doesn't coalesce VDIs, or to a special case where a recently coalesced VDI is temporarily protected against deletion. We add a 10 minutes wait before the 5th sr-destroy attempt, to give the normal garbage collector enough time to run (it should run 5 minutes after the last operation that creates a need for the GC to run). Signed-off-by: Samuel Verschelde <[email protected]>
stormi
force-pushed
the
stormi/give-time-for-GC
branch
from
bd5717e
to
ebfe49a
Compare
|
The conditions for entering the new code path are not that easy to reproduce, so let's be extra careful in the review. |
benjamreis
approved these changes
Sep 28, 2023
gthvn1
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have code which retries a failed sr-destroy, when the cause is remaining hidden VDIs which haven't been garbage-collected yet, and it's enough in most cases, but not always.
Sometimes, the force-gc that is triggered by SM before the delete operation is not enough. VDIs that look like they should be removed remain, and are removed only a bit later, when the normal garbage collector runs.
This may be related to the fact that the forced GC operation doesn't coalesce VDIs, or to a special case where a recently coalesced VDI is temporarily protected against deletion.
We add a 10 minutes wait before the 5th sr-destroy attempt, to give the normal garbage collector enough time to run (it should run 5 minutes after the last operation that creates a need for the GC to run).