Ignore GPG check for install or upgrade in the script #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me, this should be an optional parameter to the script, not something that applies to all installs. Moreover, the option is specific to XCP-ng 8.2 (and earlier) and doesn't exist in XCP-ng 8.3, IIRC (there are different options), so this should be made clear in the commit message and the script's new option. |
gduperrey
force-pushed
the
gdy-pb-gpg-netinstall
branch
from
a4001cd
to
ab8d519
Compare
stormi
reviewed
Sep 27, 2023
To circumvent the lack of signature of 8.2 ISOs, added an option to deactivate GPG verification in the answerfile. Signed-off-by: Gael Duperrey <[email protected]>
gduperrey
force-pushed
the
gdy-pb-gpg-netinstall
branch
from
ab8d519
to
d18edde
Compare
stormi
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary fix, we added an option to the script install_xcpng.py to ignore the gpg check in the install and upgrade mode. It will last until we have a signed netinstall iso to create the repo on the PXE.