Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check extras pkgs #155

Merged
merged 2 commits into from
Jul 18, 2023
Merged

check extras pkgs #155

merged 2 commits into from
Jul 18, 2023

Conversation

gthvn1
Copy link
Contributor

@gthvn1 gthvn1 commented Jul 18, 2023

No description provided.

@gthvn1
Copy link
Contributor Author

gthvn1 commented Jul 18, 2023

I closed #153 and create the same PR (this one) but in the xcp-ng repo directly in order to trigger new checks. So former discussions can be read on #153

When installing all packages together if one or more package don't exist
there is no error. Some tests are checking that packages can be installed
so we need to generate an error. To achieve this we add an option to yum
install to stop and generate an error if a package is missing.
Error is caught only for the first missing package.

Signed-off-by: Guillaume <[email protected]>
@gthvn1 gthvn1 force-pushed the gtn-check-extras-pkgs branch 3 times, most recently from faba250 to 5dc42d4 Compare July 18, 2023 14:20
jobs.py Outdated Show resolved Hide resolved
@gthvn1 gthvn1 requested a review from benjamreis July 18, 2023 14:51
This test gets a list of extra packages from
https://reports.xcp-ng.org/<xcp-ng-version>/extra_installable.txt
and checks that:
- the package is available and dependencies resolved using
  yumdownloader
- all packages can be installed. Before installing packages it
  saves the yum state and restores it after the installation.

As tests are taking some time we added them in their onw job.

Signed-off-by: Guillaume <[email protected]>
@benjamreis benjamreis requested a review from stormi July 18, 2023 14:58
@stormi
Copy link
Member

stormi commented Jul 18, 2023

@gduperrey we are about to merge this PR which adds a new test job named "packages". It must be added to the list of jobs in Jenkins. Runs in approximately 15 minutes. Can run on a virtual VM if it allows parallelizing job executions. It doesn't reboot hosts.

@stormi stormi merged commit e8655aa into master Jul 18, 2023
4 checks passed
@stormi stormi deleted the gtn-check-extras-pkgs branch July 18, 2023 15:04
@gduperrey
Copy link
Contributor

There is a problem when we run this on 8.2.1. The right url use the version 8.2 and not 8.2.1.
We need to adapt the script to generate the url or to have a link in http(s) to reach the right url.

@gduperrey
Copy link
Contributor

8.3 ✅

@gduperrey
Copy link
Contributor

8.2 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants