Skip to content

Commit

Permalink
fixup! WIP New test to check logs for errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ydirson committed Sep 18, 2024
1 parent e0a724f commit 6203ad8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/system/test_checklogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_logs(host, logfile):
result = host.ssh(["grep -B1 -Ei 'error|fail|fatal|critical|No such file'", LOGFILE],
check=False, simple_output=False)
assert result.returncode in (0, 1), "error in 'ssh grep'"
#assert result.returncode == 1, f"Errors in {logfile}, see debug output"
# assert result.returncode == 1, f"Errors in {logfile}, see debug output"
assert result.returncode == 0, f"It is NOT NORMAL AT ALL to have no error in {logfile}"

# FIXME too many false positives to be a real test, essentially useful
Expand All @@ -25,5 +25,5 @@ def test_install_logs(host):
result = host.ssh(["grep -B1 -Ei 'error|fail|fatal|critical|No such file'", LOGFILE],
check=False, simple_output=False)
assert result.returncode in (0, 1), "error in 'ssh grep'"
#assert result.returncode == 1, f"Errors in {logfile}, see debug output"
# assert result.returncode == 1, f"Errors in {logfile}, see debug output"
assert result.returncode == 0, f"It is NOT NORMAL AT ALL to have no error in {logfile}"

0 comments on commit 6203ad8

Please sign in to comment.