docs: add PCI passthrough removal instructions #146
Conversation
Signed-off-by: Bryan Vaz <[email protected]>
bryanvaz
force-pushed
the
docs/add_pci_removal_docs
branch
from
1ed8c20
to
3218c5d
Compare
Signed-off-by: Bryan Vaz <[email protected]>
bryanvaz
force-pushed
the
docs/add_pci_removal_docs
branch
from
3e0ea91
to
9715cd6
Compare
Signed-off-by: Bryan Vaz <[email protected]>
| _Note: this command removes all PCI devices hidden from the control domain (`dom0`). If you have multiple devices, you can either: (a) add them back if they are inadvertently removed; or (b) use the previous `--set-dom0` command, to update the list of hidden PCI devices, excluding the device address that you want to add back to the control domain._ | ||
|
|
||
| :::tip | ||
| You can use `cat /boot/efi/EFI/xenserver/grub.cfg` see a list of devices currently hidden under during a normal boot (`menuentry 'XCP-ng'`). The grub location will vary depending on how you setup your bootloader. |
There was a problem hiding this comment.
This is only true for UEFI hosts. The location differs for BIOS hosts.
There was a problem hiding this comment.
Oh, I see you mentioned it, but as it comes after, it can be a bit confusing.
There was a problem hiding this comment.
Yea, I don't know where the BIOS grub config is hiding.
Also on a separate note /opt/xensource/libexec/xen-cmdline --get-dom0 does not return anything on my UEFI system. This command ideally would be the best way to confirm this info.
There was a problem hiding this comment.
/etc/grub.cfg is a symlink to the grub configuration in BIOS mode and /etc/grub-efi.cfg in UEFI mode. Can you update with this information?
There was a problem hiding this comment.
The last comment was not addressed actually. I'll update the PR before we merge it.
|
Ping @bryanvaz. This PR is useful, but the comments still need addressing. |
|
Pinging @bryanvaz again. |
|
Hi @bryanvaz. It's been more than 7 months since you opened this pull request. I still consider it a useful addition but I can't merge it as is. If you don't have time to address the remaining comments, maybe you could ask on our forum for someone to finalize the guide for you? |
|
@stormi Not sure what exactly needs to be changed or how you want it changed. I've resolved the conversations. I'll let you decide if you want to merge as is and have someone correct it later, or if it's better to just not have any PCIe passthrough removal instructions than ones with my extra tips based on lessons learned from mistakes I made when I attempted this for the first time. |
Adds instructions on how to remove a PCI passthrough device from a VM and add it back to the control domain.