Skip to content

Client: WebSocket over UNIX socket #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Client: WebSocket over UNIX socket #130

merged 1 commit into from
Jun 14, 2025

Conversation

Mahad-10
Copy link
Member

closes #128

@Mahad-10 Mahad-10 requested a review from om26er June 11, 2025 14:48
@om26er
Copy link
Member

om26er commented Jun 13, 2025

This needs to be rebased on master. We only want to support "unix+ws://" for websocket.

The change should happen in

xconn-python/xconn/joiner.py

Line 8 in 31ec826

class WebsocketsJoiner:

And also

xconn-python/xconn/joiner.py

Line 38 in 31ec826

class AsyncWebsocketsJoiner:

@Mahad-10 Mahad-10 force-pushed the websocket-over-unix-socket-client branch from 1dc0796 to 2e18f2a Compare June 14, 2025 08:59
@Mahad-10 Mahad-10 merged commit 1560bd8 into xconnio:main Jun 14, 2025
2 checks passed
@Mahad-10 Mahad-10 deleted the websocket-over-unix-socket-client branch June 14, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@om26er om26er om26er approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client: WebSocket over UNIX socket
2 participants
@Mahad-10 @om26er