Skip to content

Unbork coin selection #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 10, 2025
Merged

Unbork coin selection #394

merged 18 commits into from
Apr 10, 2025

Conversation

dkackman
Copy link
Collaborator

@dkackman dkackman commented Apr 3, 2025 •
edited
Loading

I broke coin selection when adding backend paging.

#391

This fixes that.

This also:

  • moves checks for enabling Split, Combine, and Sweep to the back end
  • adds a clear selection button
  • adds a muted label to show number of selected coins

@dkackman dkackman self-assigned this Apr 3, 2025
@dkackman dkackman added the bug Something isn't working label Apr 3, 2025
@dkackman dkackman added this to the 0.10.2 milestone Apr 3, 2025
@dkackman dkackman marked this pull request as draft April 4, 2025 02:46
@dkackman dkackman marked this pull request as ready for review April 4, 2025 18:30
dkackman and others added 8 commits April 4, 2025 14:40
@dkackman
rename get_are_all_coins_spendable to get_are_coins_spendable
bc3b839
@dkackman
combine getSpendableXchCoinCount and getSpendableCatCoinCount to getS…
38a4f1b 
…pendableCoinCount
@dkackman
get coin states with a single query
11f16ce
@dkackman
get p2 coin states in a single query
4686279
@dkackman
Add get_coins_by_ids endpoint and related database query
a935192 
Implemented the get_coins_by_ids function in the Sage struct to retrieve coin states based on provided coin IDs. Updated the database layer to support this query, and added corresponding request and response structures in the API. Also modified the frontend bindings and components to integrate this new functionality.
@dkackman
use EnhancedCoinStateRow::from
6f8bd27
@Rigidity
Make coin selection UI mobile friendly
5030e4c
@dkackman
Merge pull request #2 from xch-dev/coin-selection-ui
4cbf4ff 
Make coin selection UI mobile friendly
@Rigidity Rigidity merged commit a76387c into xch-dev:main Apr 10, 2025
5 of 8 checks passed
@dkackman dkackman deleted the unbork-coin-selection branch May 7, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees

@dkackman dkackman

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dkackman @Rigidity