[WalletConnect] Allow signed message to be hex or plain #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add a switch to show hex if it was send in hex. (we do not convert to hex if the messge was plain)
* main: Add auto combine RPCs Fix partial signing prettier - enforce positive entries for default expiry - introduce a hook to share storage and validation logic "Coin" fix update hook dependency add settings, localstorage and react to settings on make offer page check that a pasted value can be converted to a number before allowing the paste. this prevents masked values from accepting ambiguous input - i.e. 0,0001 is masked to 1 prettier updated from BubbleTrouble prettier replace react-imask with NumericFormat use TokenAmountInput for fee and XCH amount entry remove log statements add onBlur handler to compensate for no onChange after a paste
Rigidity
approved these changes
Feb 26, 2025
* main: (305 commits) Make coin selection UI mobile friendly fix broken table selection via checkboxes use EnhancedCoinStateRow::from Add get_coins_by_ids endpoint and related database query get p2 coin states in a single query get coin states with a single query combine getSpendableXchCoinCount and getSpendableCatCoinCount to getSpendableCoinCount rename get_are_all_coins_spendable to get_are_coins_spendable use backend query to determine if the wallet has coins to autocombine multi-page selection of coins let sqlite do the byte conversion prettier push checking for canSplit and canCombine into the backend by add a spendability check multi page selection Revert "clear selection on sort, filter or page" clear selection on sort, filter or page fix coin selection for a single page of coins reduce tooltip flicker add random element to peer removal xch-dev#27 ... # Conflicts: # src/contexts/WalletConnectContext.tsx
… prefix. It will recognize if the message is hex or not: Message is hex if: - Start with 0x and only hex characters OR - Only hex characters Else: - it is a decoded message
Rigidity
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always show the message in plain and add a switch to show in hex if it was send in hex. We do not convert to hex if the message was sent plain.
There is one thing I didn't make is to accept hex message starting with
0x. Let me know if you want me to look at it.