Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to configib to handle Rocky9 precreated connections #7490

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dubmarm
Copy link

@dubmarm dubmarm commented Feb 19, 2025

The PR is to fix an issue with configib that fails to configure an IB connection if it already exists

The modification include

files altered: xCAT/postscripts/configib

  1. Take out a useless segment of arp_ignore and arp_filter that was clearing any sysctl.conf
  2. Create a logic to perform nmcli con add if the $nic doesnt exist ELSE perform nmcli con modify
    • Otherwise an error is thrown stating a duplicate con exists with the same name and the adjustments dont occur

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ryan Dubina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

TMP1=`sed "/net.ipv4.conf.$nic.arp_filter=1/d" /etc/sysctl.conf`
echo "$TMP1" > /etc/sysctl.conf
TMP2=`sed "/net.ipv4.conf.$nic.arp_ignore=1/d" /etc/sysctl.conf`
echo "$TMP2" > /etc/sysctl.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please readd arp_ignore and arp_filter. This is needed in IPoIB environments.
But using append/replace is probably a better idea.

@Obihoernchen
Copy link
Member

Thank you for this PR!
Can you please sign the CA?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants