timestamp added #42
Open
timestamp added #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souravray
approved these changes
Jul 3, 2019
| this.db.put(id, obj); | ||
| this._addToBucket(id, obj.data); // promise bnana hai kya | ||
| this._addToBucket(id, obj.data, time); // promise bnana hai kya |
| @@ -52,7 +75,7 @@ pipeline.source(Stream.consumer({ name: 'process-mapper' })) | |||
| // throw new Error('Kaka punjabi'); | |||
| next(data, err); | |||
| }) | |||
| .flow(Batch.map({ number: 5, timeout: 30000, groupBy: ["to", "from"], attributes: ["num", "from"], type: "leveldb" }, | |||
| .flow(Batch.map({ number: 5, timeout: 30000, groupBy: ["to", "from"], attributes: ["num", "from" , "_timestamp"], timestamp : "time" }, | |||
There was a problem hiding this comment.
user will not be aware of _timestamp.
you should programmatically return two parameters in the result (similar to our group by parameters)
- the field mention in as timestamp
- time of message Arrival
| @@ -136,16 +137,23 @@ module.exports = class LevelDb { | |||
| console.error(`can't store store inactive`); | |||
| } else { | |||
| try { | |||
| let time; | |||
There was a problem hiding this comment.
voluntarily capture both options.timesamp and message arrival timestamp and save them in the bucket.
| @@ -11,7 +11,7 @@ module.exports = class Batch extends Builder.Flow { | |||
| if (new.target === Batch) { | |||
| throw new Error('Cannot construct Batch instances directly'); | |||
| } | |||
| this._storeOptions = _.pick(options, ["number", "groupBy", "attributes", "timeout", "type", "path"]); | |||
| this._storeOptions = _.pick(options, ["number", "groupBy", "attributes", "timeout", "type", "path", "timestamp"]); | |||
There was a problem hiding this comment.
passed time stamp parameter should be treated similar to group by or attribute parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41