Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add migration start message with schema name #384

Merged

Conversation

t-ham752
Copy link
Contributor

@t-ham752 t-ham752 commented Aug 24, 2024

Hi, I noticed an issue that seemed like a quick fix, so I went ahead and made the changes.
The related issue is here:

In this PR, I made changes to prioritize using the name property in migration file. If name is empty, we fall back to using the filename.

I'd appreciate it if you could take a look when you have some time.

@t-ham752 t-ham752 marked this pull request as ready for review August 24, 2024 12:51
@t-ham752 t-ham752 force-pushed the chore/use_migration_name_intead_of_file_name branch from adb1732 to 95ca28e Compare August 24, 2024 13:40
@t-ham752 t-ham752 force-pushed the chore/use_migration_name_intead_of_file_name branch from 95ca28e to 2ea2049 Compare August 24, 2024 13:46
Copy link
Member

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thank you so much for contributing!

@exekias exekias merged commit bec15d8 into xataio:main Aug 26, 2024
22 checks passed
@t-ham752 t-ham752 deleted the chore/use_migration_name_intead_of_file_name branch August 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants