Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor attempt to clear up the behaviour in the documentation #372

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

dolezvo1
Copy link
Contributor

@dolezvo1 dolezvo1 commented Jul 17, 2024

I'm not sure what is the proper terminology for public vs public_03_add_column schemas. Major/main vs minor/specific? I think there definitely should be a consistent terminology, though.

Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the extra explanations to the docs 🎉

I've made some suggested changes to better explain the difference between the versioned schema containing the views and the base schema containing the tables.

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@dolezvo1
Copy link
Contributor Author

dolezvo1 commented Jul 23, 2024

@andrew-farries Thank you for your notes! I actually wasn't even completely aware of this. I will apply your changes and try again.

@andrew-farries andrew-farries merged commit c2635b3 into xataio:main Jul 25, 2024
22 checks passed
@dolezvo1
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants