Add edge detection filters (Sobel, Laplacian, Prewitt)#1042
Merged
brendancol merged 6 commits intomasterfrom Mar 21, 2026
Merged
Add edge detection filters (Sobel, Laplacian, Prewitt)#1042brendancol merged 6 commits intomasterfrom
brendancol merged 6 commits intomasterfrom
Conversation
Five new functions (sobel_x, sobel_y, laplacian, prewitt_x, prewitt_y) that wrap convolution_2d with fixed 3x3 kernels. All four backends (NumPy, CuPy, Dask+NumPy, Dask+CuPy) are inherited from the existing convolution infrastructure.
72 tests covering correctness, NaN handling, edge cases, boundary modes, and cross-backend (NumPy, Dask, CuPy) equivalence.
Covers sobel_x, sobel_y, laplacian, prewitt_x, prewitt_y with synthetic terrain, directional gradients, edge magnitude, Sobel vs Prewitt comparison, and boundary mode visualization.
Registers sobel_x, sobel_y, laplacian, prewitt_x, prewitt_y on both the DataArray and Dataset xrs accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xrspatial/edge_detection.pymodule with five functions:sobel_x,sobel_y,laplacian,prewitt_x,prewitt_yconvolve_2dwith a fixed 3x3 kernel, so all four backends (NumPy, CuPy, Dask+NumPy, Dask+CuPy) come for free35_Edge_Detection.ipynb) with terrain demos, Sobel vs Prewitt comparison, edge magnitude, and boundary mode visualizationdocs/source/reference/focal.rstand README feature matrix updatedCloses #1038
Test plan
pytest xrspatial/tests/test_edge_detection.pypasses (72 tests)