Add northness and eastness functions (#1039)#1041
Merged
brendancol merged 4 commits intomasterfrom Mar 20, 2026
Merged
Conversation
cos(aspect) and sin(aspect) wrappers for encoding aspect as linear variables suitable for regression and clustering. Flat cells map to NaN.
Covers correctness, cardinal directions, flat-to-NaN, NaN propagation, range checks, and backend parity (numpy, dask, cupy, dask+cupy). Also fixes CuPy compat by using np.where on raw data instead of xarray .where() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
northness()andeastness()toxrspatial.aspect, computingcos(aspect)andsin(aspect)aspect()internally, so all four backends and both methods (planar, geodesic) work with no new kernel codenp.whereon raw arrays instead of xarray's.where()method, which breaks on CuPy-backed DataArraysTest plan
test_northness_eastness.py, all passingcos(aspect)/sin(aspect)referenceCloses #1039