Fix for non-unique country codes #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial seeding somehow contains a duplicate country code, which is strange because I can't find any in the Geonames dataset. I did not explore the root cause any further. The duplication causes the initial seeding to fail because of the unique constraint. With this fix the initial seeding is able to complete without further problems.
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 79.84% 79.84%
Complexity 273 273
=========================================
Files 32 32
Lines 883 883
=========================================
Hits 705 705
Misses 178 178
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial seeding somehow contains a duplicate country code, which is strange because I can't find any in the Geonames dataset. I did not explore the root cause any further.
The duplication causes the initial seeding to fail because of the unique constraint. With this fix the initial seeding is able to complete without further problems.