Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc unsafe removals #325

Merged
merged 4 commits into from
Feb 3, 2025
Merged

misc unsafe removals #325

merged 4 commits into from
Feb 3, 2025

Conversation

conradludgate
Copy link
Contributor

This is the last one I have planned for now:

Each commit here should be fairly self explanatory.

  1. add an unchecked assertion in determine_shard to force no bounds checks later on. safety requirement is closer to the source
  2. removes the Map trait, not sure why it was ever needed
  3. removes unused type bounds from Iters
  4. removes unused unsafe markers on some functions

@xacrimon xacrimon merged commit 55f7cdf into xacrimon:master Feb 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conradludgate @xacrimon