Avoid relying on the default php.ini argument separator #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Feb 26, 2017
src/Api/HttpClient.php
Outdated
| @@ -144,7 +144,7 @@ private function request($method, $path, array $params) | |||
|
|
|||
| // append request parameters to the URL | |||
| if ('GET' === $method || 'DELETE' === $method) { | |||
| $path .= '?'.http_build_query($params); | |||
| $path .= '?'.http_build_query($params, null, '&'); | |||
There was a problem hiding this comment.
I guess the second parameter should be the empty string (see https://3v4l.org/gGkfE), shouldn't it?
|
Thank you @stof. |
xabbuh
added a commit
that referenced
this pull request
Apr 28, 2017
This PR was merged into the 1.2.x-dev branch. Discussion ---------- Avoid relying on the default php.ini argument separator Changing the default separator to something else than ``&`` in the php.ini is probably not that common, but it is possible. As this is a shared library, it cannot rely on the php.ini not being modified. So passing the separator explicitly is better. Commits ------- 70f39ec Avoid relying on the default php.ini argument separator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the default separator to something else than
&in the php.ini is probably not that common, but it is possible. As this is a shared library, it cannot rely on the php.ini not being modified. So passing the separator explicitly is better.