-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add averages with time dimension removed #236
Commits on May 10, 2022
-
Add
mean()
toTemporalAccessor
class- Update docstrings of methods in `TemporalAccessor` class - Add `DEFAULT_SEASON_CONFIG` to reduce code duplication - Add comments for sections of code that is opaque - Rename `_averager()` to `_grouped_average()`
Configuration menu - View commit details
-
Copy full SHA for 56fa075 - Browse repository at this point
Copy the full SHA 56fa075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed1906 - Browse repository at this point
Copy the full SHA 1ed1906View commit details
Commits on May 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f8ad3e - Browse repository at this point
Copy the full SHA 6f8ad3eView commit details
Commits on May 12, 2022
-
Refactor
_validate_weights()
to optimize performance- Remove `data_var` arg from `_get_weights()` - Update `_convert_df_to_dt()` to use regular dt objects for mean mode and non-monthly frequencies Add `TemporalAccessor` attribute `_dim_name` - Update docstrings
Configuration menu - View commit details
-
Copy full SHA for 360e370 - Browse repository at this point
Copy the full SHA 360e370View commit details -
Rename
TemporalAccessor
methods for consistency- Rename `.mean()` to `.average()` - Rename existing `.average()` to `.group_average()` - Update "mean" to "average" and "average" to "group_average in `Mode` type alias
Configuration menu - View commit details
-
Copy full SHA for 4a55ae8 - Browse repository at this point
Copy the full SHA 4a55ae8View commit details -
Rename methods, attributes, and variables
- Rename `_grouped_average()` to `_group_average()` - Rename `_time_grouped` to `_grouped_time` - Update docstring for `_convert_df_to_dt()` - Update conditional in `_convert_df_to_dt()` - Update `_validate_weights()` to get `num_groups` from `_get_weights()`instead of `self._time_grouped` - Rename classes in `test_temporal.py` to reflect private methods - Add placeholder tests in `test_temporal.py`
Configuration menu - View commit details
-
Copy full SHA for f5c4883 - Browse repository at this point
Copy the full SHA f5c4883View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79efc1c - Browse repository at this point
Copy the full SHA 79efc1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 360ef93 - Browse repository at this point
Copy the full SHA 360ef93View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd309f9 - Browse repository at this point
Copy the full SHA cd309f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeb249a - Browse repository at this point
Copy the full SHA eeb249aView commit details -
Update names of methods, comments, and docstrings
- Update `_group_time_coords()` to `_label_time_coords()` - Update `_groupby_freq()` to `_group_data()` - Extract `_get_dt_components()` from `_group_time_coords()` - Rename `_process_season_dataframe()` to `_process_season_df()` - Move `_convert_df_to_dt()` further down the class - Rename `DATETIME_COMPONENTS` to `TIME_GROUPS` - Update season frequency in `TIME_GROUPS` - Add logic to `_get_dt_components()` to handle seasonal frequency
Configuration menu - View commit details
-
Copy full SHA for 8f59e0c - Browse repository at this point
Copy the full SHA 8f59e0cView commit details
Commits on May 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ff55341 - Browse repository at this point
Copy the full SHA ff55341View commit details
Commits on May 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d3714be - Browse repository at this point
Copy the full SHA d3714beView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb8479b - Browse repository at this point
Copy the full SHA cb8479bView commit details -
Remove redundant tests for private methods
- Testing private methods introduces coupling to implementation details. We should be testing public methods, which tests behaviors and outputs
Configuration menu - View commit details
-
Copy full SHA for e6d7b1a - Browse repository at this point
Copy the full SHA e6d7b1aView commit details -
Update TestAverage and TestGroupAverage fixtures
- Use dataset custom dataset fixtures with less coordinate points and values other than 1 for easier and more robust testing
Configuration menu - View commit details
-
Copy full SHA for 5e8f7ab - Browse repository at this point
Copy the full SHA 5e8f7abView commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 13d34d9 - Browse repository at this point
Copy the full SHA 13d34d9View commit details -
Add
season_config
toaverage()
- Add tests for `season_config` arg - Update names of tests
Configuration menu - View commit details
-
Copy full SHA for c957760 - Browse repository at this point
Copy the full SHA c957760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131ff69 - Browse repository at this point
Copy the full SHA 131ff69View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8b60ac - Browse repository at this point
Copy the full SHA d8b60acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cffe6d - Browse repository at this point
Copy the full SHA 1cffe6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for da2cf9e - Browse repository at this point
Copy the full SHA da2cf9eView commit details
Commits on May 19, 2022
-
Add
_infer_freq()
for inferring time freq- Update `TestAverage` unit tests to test different time frequencies
Configuration menu - View commit details
-
Copy full SHA for f69df41 - Browse repository at this point
Copy the full SHA f69df41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8447736 - Browse repository at this point
Copy the full SHA 8447736View commit details
Commits on May 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2d94c2c - Browse repository at this point
Copy the full SHA 2d94c2cView commit details