Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 3 abandoned linters obsoleted by unused linter #48

Merged
merged 1 commit into from
May 5, 2024
Merged

Remove 3 abandoned linters obsoleted by unused linter #48

merged 1 commit into from
May 5, 2024

Conversation

x448
Copy link
Owner

@x448 x448 commented Apr 30, 2024

Removed deadcode, structcheck, and varcheck.

Noise removed in ci logs:

level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."

@x448
Update .golangci.yml
36d376d 
Removed 3 abandoned linters obsoleted by unused.
@x448 x448 added the ci GitHub Actions workflow label Apr 30, 2024
@x448 x448 requested a review from fxamacker April 30, 2024 20:55
@x448 x448 mentioned this pull request Apr 30, 2024
Merged
fxamacker
fxamacker approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@fxamacker fxamacker merged commit f30d7b7 into master May 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxamacker fxamacker fxamacker approved these changes

Assignees
No one assigned
Labels
ci GitHub Actions workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@x448 @fxamacker