Skip to content

fix(manifest): ensure manifest author is string, support object with email #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hellozzm
Copy link

@hellozzm hellozzm commented Jul 4, 2025

Overview

Convert author field in manifest to string if it is an object, using the email property. Add test to verify author object is correctly converted to string in the generated manifest. Prevents invalid manifest format in Firefox and other browsers.

Manual Testing

Related Issue

This PR closes #1770

… email

Convert author field in manifest to string if it is an object, using the email property.
Add test to verify author object is correctly converted to string in the generated manifest.
Prevents invalid manifest format in Firefox and other browsers.
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 0c5bd4b
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68673c2f4878f50008108813
😎 Deploy Preview https://deploy-preview-1792--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hellozzm hellozzm changed the title feat(manifest): ensure manifest author is string, support object with… fix(manifest): ensure manifest author is string, support object with email Jul 4, 2025
@aiktb
Copy link
Contributor

aiktb commented Jul 4, 2025

No browser other than Firefox needs the author. Some time ago Google removed this field from their MV3 manifest documentation reference.

As of May 2025, Chrome and the Chrome Web Store don't use this key.
Ref https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/author

I think these codes should be firefox only.

@hellozzm
Copy link
Author

hellozzm commented Jul 4, 2025

Yes, before making the revisions, I consulted the documentation:
https://developer.chrome.google.cn/docs/extensions/reference/manifest/author?hl=en

But perhaps this way of handling it can avoid reporting errors on Firefox

@Timeraa
Copy link
Member

Timeraa commented Jul 16, 2025

Does this also apply to stores like Opera, Edge Addons?

@hellozzm
Copy link
Author

Does this also apply to stores like Opera, Edge Addons?

image

As shown in the attached image, the Opera browser extension also encounters the same issue, so the solution used for Firefox can also be applied to Opera. Edge, like Chrome, does not have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Firefox manifest.json
3 participants