-
-
Notifications
You must be signed in to change notification settings - Fork 364
perf: Use filter to improve plugin performance with rolldown #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
perf: Use filter to improve plugin performance with rolldown #1787
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
packages/wxt/src/core/builders/vite/plugins/devHtmlPrerender.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
==========================================
+ Coverage 81.04% 81.13% +0.08%
==========================================
Files 130 130
Lines 6649 6723 +74
Branches 1091 1075 -16
==========================================
+ Hits 5389 5455 +66
- Misses 1249 1257 +8
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Small mistake of me, i've done |
packages/wxt/src/core/builders/vite/plugins/devHtmlPrerender.ts
Outdated
Show resolved
Hide resolved
packages/wxt/src/core/builders/vite/plugins/devHtmlPrerender.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, seems like a safe code change. Nice work!
@sm17p Thanks for your review, now code is a way simpler <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for figuring this out. Couple of comments, not sure if we need to use regex for exact matches.
packages/wxt/src/core/builders/vite/plugins/removeEntrypointMainFunction.ts
Show resolved
Hide resolved
@aklinker1 As you can see it doesn't accept strings, i've wanted to do it in more simply way, but it isn't possible. I had plan to check issues and if not open, open it on |
@aklinker1 That's in some kind of FAQ: In the very bottom of: And i haven't understand it but Perplexity helps me 😆 |
…ppConfig.ts plugin
…uginLoader.ts to remove unnecessary `?` operator
This reverts commit 8c6cc47.
…for transformIndexHtml of wxtPluginLoader.ts and add optional chaining char in the line below
2714ff4
to
43671bf
Compare
@aklinker1 Should be all good right now, let's approve workflow :) |
Overview
I've adapt
filters
instead of making if statements and handling it by JS, now it should be handled by rust and make WXT more amazing ❤️Manual Testing
Let's run
pnpm test
and check if everything works fine :)Related Issue
This PR closes #1716