feat: Ignore popup/index.ts instead of erroring #1520
+55
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aleclarson
reviewed
Mar 22, 2025
packages/wxt/src/core/utils/building/__tests__/find-entrypoints.test.ts
Outdated
Show resolved
Hide resolved
aleclarson
reviewed
Mar 22, 2025
aleclarson
reviewed
Mar 22, 2025
packages/wxt/src/core/utils/building/__tests__/find-entrypoints.test.ts
Outdated
Show resolved
Hide resolved
aklinker1
reviewed
Apr 9, 2025
Comment on lines
671
to
676
| it('should ignore other index files when index.html exists', async () => { | ||
| globMock.mockResolvedValueOnce([ | ||
| 'popup/index.html', | ||
| 'popup/index.ts', | ||
| 'popup/index.css', | ||
| ]); |
There was a problem hiding this comment.
@nishu-murmu I also made .css and any other index.* files be ignored when an index.html file exists.
aklinker1
reviewed
Apr 9, 2025
Comment on lines
-673
to
+694
| 'options/index.html', | ||
| 'options/index.jsx', | ||
| 'popup.html', | ||
| 'popup/index.html', | ||
| 'popup/index.ts', | ||
| 'ui.html', | ||
| 'other.ts', | ||
| 'other/index.ts', |
There was a problem hiding this comment.
Slightly tweaked the inputs to this test, so it tests both HTML and script entrypoints.
|
I've updated this PR. I moved the fix to the correct location and updated tests accordingly. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
aklinker1
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#1333
Manual Testing
I still wasn't able to work the second test work. Could use some help.
Related Issue
This PR closes #1333