Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Java 9 multi release jars #61 #63

Closed
wants to merge 1 commit into from
Closed

Add support for Java 9 multi release jars #61 #63

wants to merge 1 commit into from

Conversation

liamsharp
Copy link

  • A property for library jar exclusions (libraryJarExclusion)

@liamsharp
Add support for Java 9 multi release jars wvengen#61
9c39d70 
- A property for library jar exclusions (libraryJarExclusion)
@FibreFoX
Copy link
Collaborator

FibreFoX commented Dec 15, 2017 •
edited
Loading

technically LGTM, maybe the parameter-name could be something better. @wvengen / @cmorty what do you think about this new parameter/PR?

@FibreFoX FibreFoX mentioned this pull request Jan 21, 2018
Closed
@wvengen
Copy link
Owner

wvengen commented Feb 26, 2018

@cmorty any objections?
@liamsharp Github shows that there may be an indentation mismatch. Could you please check that you're using the right indentation?

@wvengen
Copy link
Owner

wvengen commented May 24, 2018

@liamsharp ping?

@liamsharp
Copy link
Author

@wvengen Whitespace fixed up, I've created a new pull request:

#75

wvengen
wvengen reviewed May 29, 2018
View reviewed changes
Copy link
Owner

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny remark, otherwise, I think it's good!

src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java
libraryJars.add(file);
} else {
args.add("-libraryjars");
args.add(fileToString(file));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks like an indentation mismatch, right?

wvengen
wvengen reviewed May 29, 2018
View reviewed changes
src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java
@@ -123,7 +123,13 @@
* @parameter default-value="false"
*/
private boolean putLibraryJarsInTempDir;


/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, also indentation mismatch

wvengen
wvengen reviewed May 29, 2018
View reviewed changes
src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java
@@ -60,7 +60,7 @@

public class ProGuardMojo extends AbstractMojo {

/**
/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more space?

@liamsharp
Copy link
Author

@wvengen Created another pull request, only found 1 indentation issue:

#76

@lasselindqvist
Copy link
Collaborator

Closing this since the new fixes are in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen left review comments

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamsharp @FibreFoX @wvengen @lasselindqvist