Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hisat2_align.wdl and update workflow.zip #148

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Change hisat2_align.wdl and update workflow.zip #148

merged 1 commit into from
Aug 27, 2024

Conversation

mhoang22
Copy link

Change hisat2_align.wdl by removing size estimation for reference_index, then zip the new analysis-wdls folder with new hisat2_align.wdl as the new workflows.zip

…dex, then zip the new analysis-wdls folder with new hisat2_align.wdl as the new workflows.zip
Copy link
Member

@malachig malachig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and we have now tested it a few times. Nothing is changed other that avoiding involving a string (or empty touched file) is a size calculation. Very low risk commit.

Copy link
Member

@chrisamiller chrisamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@malachig malachig merged commit 78de8bc into main Aug 27, 2024
2 checks passed
@malachig malachig deleted the hmy-wdl branch October 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants