Skip to content

fix(composition): change how interface field selections are validated…#3027

Open
Aenimus wants to merge 1 commit into
david/eng-5628-support-provides-on-unionfrom
david/eng-9823-change-provides-interface-field-validation
Open

fix(composition): change how interface field selections are validated…#3027
Aenimus wants to merge 1 commit into
david/eng-5628-support-provides-on-unionfrom
david/eng-9823-change-provides-interface-field-validation

Conversation

@Aenimus

@Aenimus Aenimus commented Jun 28, 2026

Copy link
Copy Markdown
Member

… in a @provides fieldset

@coderabbitai summary

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@Aenimus Aenimus requested a review from a team as a code owner June 28, 2026 00:01
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23ce3e51-a2b9-436b-9dfa-27ee13898532

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.73239% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.00%. Comparing base (76b9195) to head (85b0e2b).

Files with missing lines Patch % Lines
...tion/src/v1/normalization/normalization-factory.ts 85.71% 8 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           david/eng-5628-support-provides-on-union    #3027      +/-   ##
============================================================================
+ Coverage                                     42.97%   43.00%   +0.02%     
============================================================================
  Files                                           861      861              
  Lines                                        124930   124995      +65     
  Branches                                      10063    10078      +15     
============================================================================
+ Hits                                          53692    53756      +64     
- Misses                                        70893    70894       +1     
  Partials                                        345      345              
Files with missing lines Coverage Δ
composition/src/errors/errors.ts 83.27% <100.00%> (+0.14%) ⬆️
composition/src/types/results.ts 100.00% <ø> (ø)
composition/src/v1/normalization/types/params.ts 100.00% <ø> (ø)
composition/src/v1/normalization/types/results.ts 100.00% <100.00%> (ø)
...tion/src/v1/normalization/normalization-factory.ts 90.52% <85.71%> (-0.09%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant