Skip to content

chore: move common deps to catalog#3014

Open
comatory wants to merge 1 commit into
mainfrom
ondrej/eng-9647-move-common-deps-to-catalog
Open

chore: move common deps to catalog#3014
comatory wants to merge 1 commit into
mainfrom
ondrej/eng-9647-move-common-deps-to-catalog

Conversation

@comatory

@comatory comatory commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Put common dependencies to pnpm catalog.

How to test

Pull the branch, run pnpm install in the root, then build the affected packages:

pnpm --filter './admission-server' --filter './cdn-server' --filter './playground' --filter './studio' build

Summary by CodeRabbit

  • Chores
    • Switched several shared dependencies to use the workspace version catalog for more consistent installs.
    • Added catalog entries for the updated dependency versions used across the app.
    • No user-facing functionality changes.

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR adds postcss and @hono/node-server to the pnpm workspace catalog, then updates the affected package manifests to resolve those dependencies through catalog: references.

Changes

Catalog-based dependency resolution

Layer / File(s) Summary
Workspace catalog entries
pnpm-workspace.yaml
Adds postcss and @hono/node-server versions to the workspace catalog.
Package manifests switched to catalog resolution
admission-server/package.json, cdn-server/package.json, playground/package.json, studio/package.json
Replaces pinned postcss and @hono/node-server version specs with catalog: references in the affected package manifests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • wundergraph/cosmo#2782: Switches the same @hono/node-server dependency from a pinned version to catalog: resolution in this monorepo.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: moving shared dependencies to the pnpm catalog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.63%. Comparing base (341f51a) to head (a00f6ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3014      +/-   ##
==========================================
+ Coverage   46.51%   47.63%   +1.11%     
==========================================
  Files        1120     1140      +20     
  Lines      154916   159412    +4496     
  Branches    10055    11054     +999     
==========================================
+ Hits        72059    75933    +3874     
- Misses      81023    81624     +601     
- Partials     1834     1855      +21     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-09d9d39ebb2ab9b49ac4e02b2c79e2ad7cfe07cd-nonroot

@comatory comatory marked this pull request as ready for review June 25, 2026 09:00
@comatory comatory requested review from a team as code owners June 25, 2026 09:00
@comatory comatory enabled auto-merge (squash) June 25, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant