Skip to content

fix(router): nil Ristretto caches after graphMux shutdown#3012

Open
arutkowski00 wants to merge 1 commit into
wundergraph:mainfrom
mondaycom:adamru/upstream-bugfix-nil-graphmux-caches
Open

fix(router): nil Ristretto caches after graphMux shutdown#3012
arutkowski00 wants to merge 1 commit into
wundergraph:mainfrom
mondaycom:adamru/upstream-bugfix-nil-graphmux-caches

Conversation

@arutkowski00

Copy link
Copy Markdown

Problem

Ristretto.Close() clears cache entries but leaves cache structs referenced on the shut-down graphMux, preventing garbage collection of the old generation after config reload.

Fix

Close and nil all Ristretto cache pointers on shut-down muxes. Remove shut-down muxes from graphMuxList.

Test plan

  • go test ./router/core/...

Part of config hot-reload memory leak investigation (monday.com #3221).

Close() clears Ristretto entries but leaves cache structs referenced on
the shut-down graphMux. Nil cache pointers and remove shut-down muxes
from graphMuxList so the old generation can be collected after reload.
@arutkowski00 arutkowski00 requested a review from a team as a code owner June 24, 2026 21:13
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@arutkowski00, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 48 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 24865d93-52f0-4a99-8a9a-2d580b5f8799

📥 Commits

Reviewing files that changed from the base of the PR and between 7b40f14 and df3ad45.

📒 Files selected for processing (1)
  • router/core/graph_server.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant