fix(router): drain websocket subscriptions before plan cache close#3010
fix(router): drain websocket subscriptions before plan cache close#3010arutkowski00 wants to merge 1 commit into
Conversation
Close active client websocket subscriptions synchronously at the start of graphMux shutdown so preparedPlan and executor references are released before Ristretto plan caches are closed.
|
Warning Review limit reached
More reviews will be available in 23 minutes and 57 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
During
graphMuxshutdown, Ristretto plan caches were closed while active client websocket subscriptions could still holdpreparedPlanand executor references.Fix
Close websocket subscriptions synchronously at the start of
graphMux.Shutdown(), before plan caches are closed.Test plan
go test ./router/core/...Part of config hot-reload memory leak investigation (monday.com #3221).